Merge branch 'BRCD_3595_new_features_mdb4' into 'new_features_mdb4'

BRCD-3595 :  Fix for future subscribers being charged in (relative) past cycles

See merge request sdoc/billrun!4586

library/Billrun/Plans/Charge/Upfront/Custom.php

@@ -18,6 +18,11 @@ class Billrun_Plans_Charge_Upfront_Custom extends Billrun_Plans_Charge_Upfront_M
 
 	protected function getFractionOfMonth() {
 
+		//got a future subscriber for  some reason.
+		if( $this->activation >= $this->cycle->end()) {
+			return null;
+		}
+
 		if ((empty($this->deactivation) || $this->deactivation >= $this->cycle->end() ) && $this->activation < $this->cycle->start()  ) {
 			return 1;
 		}

library/Billrun/Plans/Charge/Upfront/Month.php

@@ -19,6 +19,10 @@ class Billrun_Plans_Charge_Upfront_Month extends Billrun_Plans_Charge_Upfront {
 	 * @return int
 	 */
 	protected function getFractionOfMonth() {
+		//got a future subscriber for  some reason.
+		if( $this->activation >= $this->cycle->end()) {
+			return null;
+		}
 
 		if (empty($this->deactivation) && $this->activation < $this->cycle->start()  ) {
 			return 1;